This repository was archived by the owner on Sep 9, 2020. It is now read-only.
appveyor.yml: fix failure to detect windows build errors #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates #542 Try another way to test all the packages in this project, sans vendor/, without accidentally swallowing the exit status.
|
@sdboyer this is ready to review. Sorry about the build breakage. Fortunately when Go 1.9 comes out, we won't have to maintain this kludge, /ht golang/go#19090 |
|
@sdboyer ping, this is ready for review. |
|
ah crap, i forgot to click merge the other night. i can't really say LGTM, because i have just no idea, but the testing history does seem to indicate we're on better footing. Sooo...ty for this! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #542
Try another way to test all the packages in this project, sans vendor/,
without accidentally swallowing the exit status.