This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps, gps/pkgtree: remove DEPTESTBYPASS501 environment variable #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah yes ty - just needs a quick rerolling/rebase after the gps move. |
|
Rebased |
|
still seeing the same problem on travis as we originally did 😢 |
|
we still don't know why this error is hanging around (magic/more magic, anybody?), but having a PR hanging open isn't helping, either :( closing for cleanliness. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
Fixes #504
The underlying cause of the issue requiring the DEPTESTBYPASS501
workaround has been addressed. Remove DEPTESTBYPASS501 from test code
and CI config files.