-
Notifications
You must be signed in to change notification settings - Fork 18k
debug/pe: reading debug_info section of PE files that use the DWARF5 form DW_FORM_line_strp causes error #49590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Change https://golang.org/cl/363894 mentions this issue: |
Change https://golang.org/cl/363895 mentions this issue: |
We need fix in 1.16 too! |
When a DW_FORM_line_strp is used without a debug_line_str section a good error message (about the missing section) is generated but immediately overwritten by the underflow error generated by trying to read the non-existent section. Updates #49590 Change-Id: I1c431392123a86c78c95ef1f185ebd6f17f2476a Reviewed-on: https://go-review.googlesource.com/c/go/+/363894 Run-TryBot: Alessandro Arzilli <[email protected]> Trust: David Chase <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
any change to get this backported? AFAIK otherwise debugging does not work if the application needs gcc to build and gcc is >=11 |
@gopherbot Please open backport issues. This change is reportedly required on Windows systems using current versions of GCC. |
Backport issue(s) opened: #50721 (for 1.16), #50722 (for 1.17). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
Change https://golang.org/cl/379914 mentions this issue: |
Change https://golang.org/cl/379915 mentions this issue: |
…sections Adds the same logic used in debug/elf to load DWARF5 sections. For #49590 Fixes #50721 Change-Id: Iee05b9927a6f521842b330eab8942ade3fc2bd86 Reviewed-on: https://go-review.googlesource.com/c/go/+/363895 Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Than McIntosh <[email protected]> (cherry picked from commit 6c36c33) Reviewed-on: https://go-review.googlesource.com/c/go/+/379915 Trust: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Alessandro Arzilli <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]>
…sections Adds the same logic used in debug/elf to load DWARF5 sections. For #49590 Fixes #50722 Change-Id: Iee05b9927a6f521842b330eab8942ade3fc2bd86 Reviewed-on: https://go-review.googlesource.com/c/go/+/363895 Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Than McIntosh <[email protected]> (cherry picked from commit 6c36c33) Reviewed-on: https://go-review.googlesource.com/c/go/+/379914 Trust: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Alessandro Arzilli <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]>
Trying to read debug_info sections in PE files that use the form DW_FORM_line_strp will return the error
decoding dwarf section line_str at offset 0x0: underflow
.The text was updated successfully, but these errors were encountered: