Skip to content

debug/pe: reading debug_info section of PE files that use the DWARF5 form DW_FORM_line_strp causes error [1.16 backport] #50721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jan 20, 2022 · 2 comments
Closed

debug/pe: reading debug_info section of PE files that use the DWARF5 form DW_FORM_line_strp causes error [1.16 backport] #50721

gopherbot opened this issue Jan 20, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.14

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #49590 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport issues.

This change is reportedly required on Windows systems using current versions of GCC.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 20, 2022
@gopherbot gopherbot mentioned this issue Jan 20, 2022
Closed
@gopherbot gopherbot added this to the Go1.16.14 milestone Jan 20, 2022
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/379915 mentions this issue: [release-branch.go1.16] debug/pe,debug/macho: add support for DWARF5 sections

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Feb 3, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 3, 2022
gopherbot pushed a commit that referenced this issue Feb 3, 2022
@aarzilli @ianlancetaylor
[release-branch.go1.16] debug/pe,debug/macho: add support for DWARF5 …
355915b 
…sections

Adds the same logic used in debug/elf to load DWARF5 sections.

For #49590
Fixes #50721

Change-Id: Iee05b9927a6f521842b330eab8942ade3fc2bd86
Reviewed-on: https://go-review.googlesource.com/c/go/+/363895
Reviewed-by: Ian Lance Taylor <[email protected]>
Trust: Than McIntosh <[email protected]>
(cherry picked from commit 6c36c33)
Reviewed-on: https://go-review.googlesource.com/c/go/+/379915
Trust: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Alessandro Arzilli <[email protected]>
Reviewed-by: Emmanuel Odeke <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging 355915b to release-branch.go1.16.

@golang golang locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.14
Development

No branches or pull requests
2 participants
@toothrot @gopherbot