net/http: add Request.CookiesNamed #61473

timofurrer · 2023-07-20T09:58:06Z

Implements a new method http.Request.CookiesName, that allows
retrieving all cookies that match the given name.

google-cla · 2023-07-20T09:58:11Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2023-07-20T10:07:10Z

This PR (HEAD: fec0c13) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-20T10:13:41Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-20T10:13:53Z

This PR (HEAD: ec7cc31) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-20T16:24:55Z

Message from Damien Neil:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-07-21T05:29:22Z

This PR (HEAD: 68535d4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-14T07:31:35Z

Message from Timo Furrer:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T13:59:55Z

Message from t hepudds:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T15:15:10Z

Message from Timo Furrer:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T15:15:10Z

Message from Carl Johnson:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T15:22:06Z

Message from Timo Furrer:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-14T15:22:15Z

This PR (HEAD: 8068c69) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-02T12:52:26Z

This PR (HEAD: c16a373) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-21T18:17:32Z

Message from Damien Neil:

Patch Set 7: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T18:25:11Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-21T18:11:07Z","revision":"df80699e724ca7968190c4b2a311753629691629"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T18:25:12Z

Message from Damien Neil:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T18:25:12Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 511516)
tools on master (commit 53ad329)

error: failed to run "test golang.org/x/tools module": exit status 1
failed to run "test golang.org/x/tools/gopls module": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T18:25:13Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T19:18:10Z

Message from Damien Neil:

Patch Set 7: -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T13:24:02Z

This PR (HEAD: dcf4eab) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-08T13:31:19Z

Message from Timo Furrer:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T19:31:10Z

Message from Damien Neil:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T19:31:10Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-08T19:22:23Z","revision":"fa7cfef23c7944a2221cc2a96cb29c6482ad445f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T19:51:56Z

Message from Damien Neil:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T19:51:56Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-08T19:51:57Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-11T07:20:26Z

Message from Timo Furrer:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-25T22:14:11Z

Message from Emmanuel Odeke:

Patch Set 8:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T06:40:54Z

This PR (HEAD: 7d4a032) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-26T06:47:34Z

Message from Timo Furrer:

Patch Set 8:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T06:47:42Z

This PR (HEAD: 2da44ed) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-26T08:58:31Z

Message from Emmanuel Odeke:

Patch Set 10: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T09:05:04Z

Message from Gopher Robot:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T09:18:30Z

Message from Gopher Robot:

Patch Set 10: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T18:13:03Z

Message from Damien Neil:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

This commit implements the new API proposed with golang#61472 Implements a new method http.Request.CookiesName, that allows retrieving all cookies that match the given name. Fixes golang#61472

gopherbot · 2024-02-28T06:07:20Z

This PR (HEAD: 6ad0094) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/511516.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-28T06:13:25Z

Message from Timo Furrer:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T17:22:53Z

Message from Damien Neil:

Patch Set 11: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T17:22:54Z

Message from Go LUCI:

Patch Set 11:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-28T17:17:17Z","revision":"bc45a67ac455a1b98409c91ddec6ac7674525c0e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T17:50:22Z

Message from Damien Neil:

Patch Set 11: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T17:50:23Z

Message from Go LUCI:

Patch Set 11:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T17:50:23Z

Message from Go LUCI:

Patch Set 11: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-29T18:47:42Z

Message from Carlos Amedee:

Patch Set 11: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

Implements a new method http.Request.CookiesName, that allows retrieving all cookies that match the given name. Fixes #61472 Change-Id: I405d8771b4195af9ff6b4dfde3cfcd316c23b70c GitHub-Last-Rev: 6ad0094 GitHub-Pull-Request: #61473 Reviewed-on: https://go-review.googlesource.com/c/go/+/511516 Reviewed-by: Emmanuel Odeke <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Damien Neil <[email protected]>

gopherbot · 2024-03-20T16:18:12Z

Message from Timo Furrer:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/511516.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-20T16:24:31Z

This PR is being closed because golang.org/cl/511516 has been merged.

timofurrer mentioned this pull request Jul 20, 2023

net/http: add Request.CookiesNamed #61472

Closed

timofurrer force-pushed the read-cookies branch from d198cda to fec0c13 Compare July 20, 2023 10:02

timofurrer force-pushed the read-cookies branch from fec0c13 to ec7cc31 Compare July 20, 2023 10:08

timofurrer force-pushed the read-cookies branch from ec7cc31 to 68535d4 Compare July 21, 2023 05:25

timofurrer changed the title ~~net/http: introduce ReadCookies() API for Request~~ net/http: add Request.CookiesNamed Jul 21, 2023

timofurrer force-pushed the read-cookies branch from 68535d4 to 8068c69 Compare September 14, 2023 15:16

timofurrer force-pushed the read-cookies branch from 8068c69 to c16a373 Compare October 2, 2023 12:45

timofurrer force-pushed the read-cookies branch from c16a373 to dcf4eab Compare January 8, 2024 13:22

timofurrer force-pushed the read-cookies branch from dcf4eab to 7d4a032 Compare February 26, 2024 06:37

timofurrer force-pushed the read-cookies branch from 7d4a032 to 2da44ed Compare February 26, 2024 06:42

net/http: add Request.CookiesNamed

6ad0094

This commit implements the new API proposed with golang#61472 Implements a new method http.Request.CookiesName, that allows retrieving all cookies that match the given name. Fixes golang#61472

timofurrer force-pushed the read-cookies branch from 2da44ed to 6ad0094 Compare February 28, 2024 06:04

gopherbot closed this Mar 20, 2024

net/http: add Request.CookiesNamed #61473

net/http: add Request.CookiesNamed #61473

Conversation

timofurrer commented Jul 20, 2023 • edited Loading

google-cla bot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 21, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Sep 14, 2023

gopherbot commented Oct 2, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Jan 8, 2024

gopherbot commented Feb 11, 2024

gopherbot commented Feb 25, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 29, 2024

gopherbot commented Mar 20, 2024

gopherbot commented Mar 20, 2024

timofurrer commented Jul 20, 2023 •

edited

Loading