Skip to content

net/http: add Request.CookiesNamed #61473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/next/61472.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pkg net/http, method (*Request) CookiesNamed(string) []*Cookie #61472
9 changes: 9 additions & 0 deletions src/net/http/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,15 @@ func (r *Request) Cookies() []*Cookie {
return readCookies(r.Header, "")
}

// CookiesNamed parses and returns the named HTTP cookies sent with the request
// or an empty slice if none matched.
func (r *Request) CookiesNamed(name string) []*Cookie {
if name == "" {
return []*Cookie{}
}
return readCookies(r.Header, name)
}

// ErrNoCookie is returned by Request's Cookie method when a cookie is not found.
var ErrNoCookie = errors.New("http: named cookie not present")

Expand Down
71 changes: 71 additions & 0 deletions src/net/http/request_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"context"
"crypto/rand"
"encoding/base64"
"encoding/json"
"errors"
"fmt"
"io"
Expand Down Expand Up @@ -1256,6 +1257,76 @@ func TestRequestCookie(t *testing.T) {
}
}

func TestRequestCookiesByName(t *testing.T) {
tests := []struct {
in []*Cookie
filter string
want []*Cookie
}{
{
in: []*Cookie{
{Name: "foo", Value: "foo-1"},
{Name: "bar", Value: "bar"},
},
filter: "foo",
want: []*Cookie{{Name: "foo", Value: "foo-1"}},
},
{
in: []*Cookie{
{Name: "foo", Value: "foo-1"},
{Name: "foo", Value: "foo-2"},
{Name: "bar", Value: "bar"},
},
filter: "foo",
want: []*Cookie{
{Name: "foo", Value: "foo-1"},
{Name: "foo", Value: "foo-2"},
},
},
{
in: []*Cookie{
{Name: "bar", Value: "bar"},
},
filter: "foo",
want: []*Cookie{},
},
{
in: []*Cookie{
{Name: "bar", Value: "bar"},
},
filter: "",
want: []*Cookie{},
},
{
in: []*Cookie{},
filter: "foo",
want: []*Cookie{},
},
}

for _, tt := range tests {
t.Run(tt.filter, func(t *testing.T) {
req, err := NewRequest("GET", "http://example.com/", nil)
if err != nil {
t.Fatal(err)
}
for _, c := range tt.in {
req.AddCookie(c)
}

got := req.CookiesNamed(tt.filter)

if !reflect.DeepEqual(got, tt.want) {
asStr := func(v any) string {
blob, _ := json.MarshalIndent(v, "", " ")
return string(blob)
}
t.Fatalf("Result mismatch\n\tGot: %s\n\tWant: %s", asStr(got), asStr(tt.want))
}
})
}
}

const (
fileaContents = "This is a test file."
filebContents = "Another test file."
Expand Down