test/integration: use default GOPATH when the env var is not set #8
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: a49a3c63e9720d73f363931e4195965fae969865) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223177 to see it. Tip: You can toggle comments from me using the |
If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync.
|
This PR (HEAD: 64099f2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223177 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: c071beb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223177 to see it. Tip: You can toggle comments from me using the |
|
Message from Andrew Bonventre: Patch Set 3: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/223177. |
|
Message from Andrew Bonventre: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/223177. |
|
This PR (HEAD: 6222158) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223177 to see it. Tip: You can toggle comments from me using the |
If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync. Update #6 Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183 GitHub-Last-Rev: 6222158 GitHub-Pull-Request: #8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177 Reviewed-by: Andrew Bonventre <[email protected]>
|
Message from Hyang-Ah Hana Kim: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/223177. |
|
This PR is being closed because golang.org/cl/223177 has been merged. |
If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync. Update golang/vscode-go#6 Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183 GitHub-Last-Rev: 6222158 GitHub-Pull-Request: golang/vscode-go#8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177 Reviewed-by: Andrew Bonventre <[email protected]>
If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync. Update golang/vscode-go#6 Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183 GitHub-Last-Rev: 6222158 GitHub-Pull-Request: golang/vscode-go#8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177 Reviewed-by: Andrew Bonventre <[email protected]>
* test/integration: use default GOPATH when the env var is not set If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync. Update golang/vscode-go#6 Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183 GitHub-Last-Rev: 6222158 GitHub-Pull-Request: golang/vscode-go#8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177 Reviewed-by: Andrew Bonventre <[email protected]> * test/integration: resolve gopath in suiteSetup hook
If the env var GOPATH is not set when the test runs,
now it runs
go env GOPATHto retrieve the default valuethe underlying go commands will use. I wished I could make
this command run asynchronously, but I am not familiar with
the test framework and failed to make it working with
async functions. So, like many other file operations used in
the test setup phase, I am using execFileSync.
Update #6