This repository was archived by the owner on Jul 15, 2023. It is now read-only.
test/integration: use default GOPATH when the env var is not set #3117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Mar 24, 2020
If the env var GOPATH is not set when the test runs, now it runs `go env GOPATH` to retrieve the default value the underlying go commands will use. I wished I could make this command run asynchronously, but I am not familiar with the test framework and failed to make it working with async functions. So, like many other file operations used in the test setup phase, I am using execFileSync. Update golang/vscode-go#6 Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183 GitHub-Last-Rev: 6222158 GitHub-Pull-Request: golang/vscode-go#8 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177 Reviewed-by: Andrew Bonventre <[email protected]>
ramya-rao-a
approved these changes
Mar 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the env var GOPATH is not set when the test runs,
now it runs
go env GOPATHto retrieve the default valuethe underlying go commands will use. I wished I could make
this command run asynchronously, but I am not familiar with
the test framework and failed to make it working with
async functions. So, like many other file operations used in
the test setup phase, I am using execFileSync.
Update golang/vscode-go#6
Change-Id: Id075827ab8ebd955f7a86460aaa7ea4e0e7cd183
GitHub-Last-Rev: 6222158
GitHub-Pull-Request: golang/vscode-go#8
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223177
Reviewed-by: Andrew Bonventre [email protected]