Skip to content

update file & translate to Chinese #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update file & translate to Chinese #1334

wants to merge 1 commit into from

Conversation

SwiftSIQI
Copy link
Collaborator

No description provided.

@SwiftSIQI
Copy link
Collaborator Author

SwiftSIQI commented Oct 10, 2023

@henrif75 after review and merge your pr.
I try to continue translate the book to Chinese, this is my new PR.
It seems that I can't add myself as the reviewer, Could you give me a approve?
By the way, there are so many change, even if i just translate id 0 - id 500 sentences, Is that OK?
I was using Poedit to edit .po file

@mgeisler
Copy link
Collaborator

By the way, there are so many change, even if i just translate id 0 - id 500 sentences, Is that OK?
I was using Poedit to edit .po file

I see many changes because Poedit has re-wrapped existing translations. Is it possible that you haven't configured Poedit to stop reformatting the file?

@nodmp, @wnghl, @superwhd, @anlunx, etc... I'm sure you had to deal with this as well?

@SwiftSIQI
Copy link
Collaborator Author

By the way, there are so many change, even if i just translate id 0 - id 500 sentences, Is that OK?
I was using Poedit to edit .po file

I see many changes because Poedit has re-wrapped existing translations. Is it possible that you haven't configured Poedit to stop reformatting the file?

@nodmp, @wnghl, @superwhd, @anlunx, etc... I'm sure you had to deal with this as well?

@mgeisler this is my Poedit setting, I think the current setup meets expectations
image

@SwiftSIQI
Copy link
Collaborator Author

@mgeisler @henrif75
Anyone can help me ?

@henrif75
Copy link
Collaborator

@mgeisler @henrif75 Anyone can help me ?

I'm taking a look.

@henrif75
Copy link
Collaborator

@mgeisler @henrif75 Anyone can help me ?

I'm taking a look.

The issue stems from using the normalizer before and the current file format is clunky. The msgmerge and POEdit kinda "fixed" that, but the diff is just huge.

My suggestion is send a PR just reformatting the PO file and all subsequent PRs will be much easier.
Let me do that right away, and then you can refresh this PR and see if the diff gets better.

@henrif75
Copy link
Collaborator

Sent #1337

@SwiftSIQI SwiftSIQI closed this Oct 11, 2023
@SwiftSIQI SwiftSIQI reopened this Oct 11, 2023
@SwiftSIQI SwiftSIQI closed this by deleting the head repository Oct 11, 2023
@mgeisler
Copy link
Collaborator

Sent #1337

Since we're seeing more of these problems, I think we should consider enforcing a standard format on the PO files. #1359 does that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants