Skip to content

zh-CN: Restores PO file structure format #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

zh-CN: Restores PO file structure format #1337

merged 1 commit into from
Oct 11, 2023

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Oct 10, 2023 •
edited
Loading

This will restore the regular structure format of the PO file (line breaks and wrap) and does not change the content itself. Part of #324

@henrif75
zh-CN: Restores PO file structure format
7495399 
This will restore the regular structure file format (line breaks and wrap) and does not change the content itself.
Part of google#324
@henrif75 henrif75 marked this pull request as ready for review October 10, 2023 19:09
@henrif75 henrif75 mentioned this pull request Oct 10, 2023
Closed
@SwiftSIQI SwiftSIQI merged commit fb3f58f into google:main Oct 11, 2023
@SwiftSIQI
Copy link
Collaborator

Hi, @henrif75 I check the restores PO file structure format, It seem ok!
but the publish part seems times out?

@henrif75
Copy link
Collaborator Author

Hi, @henrif75 I check the restores PO file structure format, It seem ok! but the publish part seems times out?

@mgeisler I tried to re-run and I'm getting the same problem, would you know what's wrong with the action?

@henrif75 henrif75 deleted the zh-CN-reformat branch October 11, 2023 03:05
@henrif75
Copy link
Collaborator Author

Hi, @henrif75 I check the restores PO file structure format, It seem ok! but the publish part seems times out?

@mgeisler I tried to re-run and I'm getting the same problem, would you know what's wrong with the action?

I guess it was a transient problem, the workflow worked correctly now.

@mgeisler
Copy link
Collaborator

Hi, @henrif75 I check the restores PO file structure format, It seem ok! but the publish part seems times out?

@mgeisler I tried to re-run and I'm getting the same problem, would you know what's wrong with the action?

I guess it was a transient problem, the workflow worked correctly now.

Yeah, I don't know why it would timeout — luckily it seems fine now.

@mgeisler
Copy link
Collaborator

This would have been unnecessary with #1359, which would have rejected the PR that changed the formatting in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwiftSIQI SwiftSIQI SwiftSIQI approved these changes

@suetfei suetfei Awaiting requested review from suetfei

@wnghl wnghl Awaiting requested review from wnghl wnghl is a code owner

@anlunx anlunx Awaiting requested review from anlunx anlunx is a code owner

@kongy kongy Awaiting requested review from kongy kongy is a code owner

@NoahDragon NoahDragon Awaiting requested review from NoahDragon NoahDragon is a code owner

@superwhd superwhd Awaiting requested review from superwhd superwhd is a code owner

@emmali01 emmali01 Awaiting requested review from emmali01 emmali01 is a code owner

Assignees
No one assigned
Labels
translation/zh-CN translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrif75 @SwiftSIQI @mgeisler