Updates for OpenBSD build support#4257
Merged
lperron merged 1 commit intogoogle:stablefrom Jun 5, 2024
ron-at-swgy:OpenBSD-Updates
Merged
Updates for OpenBSD build support#4257lperron merged 1 commit intogoogle:stablefrom ron-at-swgy:OpenBSD-Updates
lperron merged 1 commit intogoogle:stablefrom
ron-at-swgy:OpenBSD-Updates
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
OpenBSD does not have a /proc filesystem OpenBSD also defines `getrusage` in sys/resource.h Add OpenBSD classifier to python package Include OpenBSD in machine/endian.h check
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds several references to the system identifier
__OpenBSD__inchecks where
__FreeBSD__is included. I have validated that each of the FreeBSDchecks are also appropriate for OpenBSD.
It should be noted that I'm still working through a completely successful build, but these changes are necessary to make incremental progress towards that goal.
First, the
fenvstructure definition referenced inortools/util/fp_utils.hfenv in
fp_utilsThe
fenvstruct is similar in shape to that of FreeBSD. For reference, the official CVSWeb repository shows a definition of:This is in alignment with that of the FreeBSD project.
Changes in sysinfo.cc
The file
ortools/base/sysinfo.ccuses a number of system calls andexpects a
/procfilesystem in some cases. Like FreeBSD, OpenBSD alsodefines
getrusageinsys/resource.h, has no proc filesystem, andneeds to include
sys/time.h.References:
Update to python package
The
ortools/python/setup.py.infile has been updated to include OpenBSDas a classified for the package targets.
Update zvector
The
ortools/util/zvector.hheader should includemachine/endian.h,just like FreeBSD.
References: