Use correct fp_env definition for OpenBSD#4259
Merged
Mizux merged 1 commit intogoogle:stablefrom Jun 5, 2024
ron-at-swgy:openbsd-fpenv
Merged
Use correct fp_env definition for OpenBSD#4259Mizux merged 1 commit intogoogle:stablefrom ron-at-swgy:openbsd-fpenv
Mizux merged 1 commit intogoogle:stablefrom
ron-at-swgy:openbsd-fpenv
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This commit includes OpenBSD in the list of definitions checked when adding exceptions to the control flags of the floating point environment on OpenBSD. Similar to FreeBSD, the flags are contained in an x87 struct within the fp_env structure. For reference, the [official CVSWeb repository](https://cvsweb.openbsd.org/src/sys/arch/amd64/include/fenv.h?rev=1.4&content-type=text/x-cvsweb-markup) shows a definition of: ```c /* * fenv_t represents the entire floating-point environment. */ typedef struct { struct { unsigned int __control; /* Control word register */ unsigned int __status; /* Status word register */ unsigned int __tag; /* Tag word register */ unsigned int __others[4]; /* EIP, Pointer Selector, etc */ } __x87; unsigned int __mxcsr; /* Control, status register */ } fenv_t; ```
Mizux
pushed a commit
that referenced
this pull request
Jun 5, 2024
This commit includes OpenBSD in the list of definitions checked when adding exceptions to the control flags of the floating point environment on OpenBSD. Similar to FreeBSD, the flags are contained in an x87 struct within the fp_env structure. For reference, the [official CVSWeb repository](https://cvsweb.openbsd.org/src/sys/arch/amd64/include/fenv.h?rev=1.4&content-type=text/x-cvsweb-markup) shows a definition of: ```c /* * fenv_t represents the entire floating-point environment. */ typedef struct { struct { unsigned int __control; /* Control word register */ unsigned int __status; /* Status word register */ unsigned int __tag; /* Tag word register */ unsigned int __others[4]; /* EIP, Pointer Selector, etc */ } __x87; unsigned int __mxcsr; /* Control, status register */ } fenv_t; ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes OpenBSD in the list of definitions checked when adding exceptions to the control flags of the floating point environment on OpenBSD. Similar to FreeBSD, the flags are contained in an x87 struct within the fp_env structure.
For reference, the official CVSWeb repository shows a definition of:
Note
This change was intended to be included in #4257 but was erroneously left out when I packaged the PR yesterday.