-
Notifications
You must be signed in to change notification settings - Fork 2.4k
elfutils: add new fuzzer #7393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
elfutils: add new fuzzer #7393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
approved these changes
Mar 16, 2022
evverx
added a commit
to evverx/oss-fuzz
that referenced
this pull request
Mar 23, 2022
Unlike fuzz-dwfl-core, the new fuzz targets actually use zlib so instead of just linking against zlib to make them compile they should use the library instrumented with MSan. Without it OSS-Fuzz reports bogus issues like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45630 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45631 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45633. To hopefully make it easier to figure out how to add new fuzz targets going forward I also added the following comment to the build script ``` When new fuzz targets are added it usually makes sense to notify the maintainers of the elfutils project using the mailing list: [email protected]. There fuzz targets can be reviewed properly (to make sure they don't fail to compile with -Werror for example), their names can be chosen accordingly (so as not to spam the mailing list with bogus bug reports that are opened and closed once they are renamed) and so on. Also since a lot of bug reports coming out of the blue aren't exactly helpful fuzz targets should probably be added one at a time to make it easier to keep track of them. ``` It's a follow-up to google#7395 and google#7393.
jonathanmetzman
pushed a commit
that referenced
this pull request
Mar 24, 2022
Unlike fuzz-dwfl-core, the new fuzz targets actually use zlib so instead of just linking against zlib to make them compile they should use the library instrumented with MSan. Without it OSS-Fuzz reports bogus issues like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45630 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45631 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45633. To hopefully make it easier to figure out how to add new fuzz targets going forward I also added the following comment to the build script ``` When new fuzz targets are added it usually makes sense to notify the maintainers of the elfutils project using the mailing list: [email protected]. There fuzz targets can be reviewed properly (to make sure they don't fail to compile with -Werror for example), their names can be chosen accordingly (so as not to spam the mailing list with bogus bug reports that are opened and closed once they are renamed) and so on. Also since a lot of bug reports coming out of the blue aren't exactly helpful fuzz targets should probably be added one at a time to make it easier to keep track of them. ``` It's a follow-up to #7395 and #7393.
MartinPetkov
pushed a commit
to MartinPetkov/oss-fuzz
that referenced
this pull request
Aug 15, 2022
MartinPetkov
pushed a commit
to MartinPetkov/oss-fuzz
that referenced
this pull request
Aug 15, 2022
Unlike fuzz-dwfl-core, the new fuzz targets actually use zlib so instead of just linking against zlib to make them compile they should use the library instrumented with MSan. Without it OSS-Fuzz reports bogus issues like https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45630 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45631 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45633. To hopefully make it easier to figure out how to add new fuzz targets going forward I also added the following comment to the build script ``` When new fuzz targets are added it usually makes sense to notify the maintainers of the elfutils project using the mailing list: [email protected]. There fuzz targets can be reviewed properly (to make sure they don't fail to compile with -Werror for example), their names can be chosen accordingly (so as not to spam the mailing list with bogus bug reports that are opened and closed once they are renamed) and so on. Also since a lot of bug reports coming out of the blue aren't exactly helpful fuzz targets should probably be added one at a time to make it easier to keep track of them. ``` It's a follow-up to google#7395 and google#7393.
evverx
added a commit
to evverx/oss-fuzz
that referenced
this pull request
Sep 18, 2022
Now fuzz-libdwfl and fuzz-libelf can be run a few times in a row with files triggering crashes. It's another follow-up to google#7395 and google#7393.
jonathanmetzman
pushed a commit
that referenced
this pull request
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.