[elfutils] create tmpfiles properly #7408
Conversation
evverx
force-pushed
the
elfutils-tmpfiles
branch
from
1396628 to
40e33e1
Compare
|
Do we still want to land this? |
Now fuzz-libdwfl and fuzz-libelf can be run a few times in a row with files triggering crashes. It's another follow-up to google#7395 and google#7393.
to make sure they are in more or less good shape
```
fuzz-libdwfl.c:54:10: error: unused variable 'res' [-Werror,-Wunused-variable]
Dwarf *res = dwfl_module_getdwarf(mod, &bias);
^
1 error generated.
```
```
fuzz-dwfl-core.c:41:11: error: comparison of integers of different signs: 'ssize_t' (aka 'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
assert(n == size);
~ ^ ~~~~
```
evverx
force-pushed
the
elfutils-tmpfiles
branch
from
e5f3881 to
279c930
Compare
|
I thought the PR was merged (and even backported the fuzz targets downstream) but it seems I forgot to mark it "ready for review". I've just rebased it on top of the master branch and I think it should be good to go. |
It should be kept elsewhere.
|
I also pushed a commit where I removed the fuzz-dwfl-core seed corpus. |
| @@ -38,7 +38,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | |||
| assert(fd >= 0); | |||
|
|
|||
| n = write(fd, data, size); | |||
| assert(n == size); | |||
| assert(n == (ssize_t) size); | |||
|
|
|||
| offset = lseek(fd, 0, SEEK_SET); | |||
| assert(offset == 0); | |||
There was a problem hiding this comment.
I don't think it's as important to remove existing zips, the space is already taken up in the git history (I guess removing zips makes --depth 1 faster). But not adding new ones is good policy
Agreed. Without rewriting the history it doesn't help to save the space much. The idea was to make the elfutils project consistent with the new policy to for example prevent this pattern from being used if the build script is borrowed as a template for new integrations. |
Now fuzz-libdwfl and fuzz-libelf can be run a few times in a row
with files triggering crashes.
It's another follow-up to #7395
and #7393.