Skip to content

feat: reset retry mechanism on failure with next loader #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

louisnow
Copy link
Contributor

@louisnow louisnow commented Nov 14, 2020

Fixes #101 🦕
Will not reset the retry mechanism until all retry attempts have been exhausted.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2020
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #102 (e15916e) into master (4c5eac0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          110       117    +7     
  Branches        23        24    +1     
=========================================
+ Hits           110       117    +7     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779ee18...2b80560. Read the comment docs.

@louisnow louisnow force-pushed the feat/reset-retry-next-loader branch from 062495a to 2b80560 Compare November 14, 2020 13:15
@louisnow louisnow mentioned this pull request Nov 14, 2020
@jpoehnelt jpoehnelt merged commit e0f6651 into googlemaps:master Nov 16, 2020
github-actions bot pushed a commit that referenced this pull request Nov 16, 2020
# [1.11.0](v1.10.0...v1.11.0) (2020-11-16)

### Features

* reset retry mechanism on failure with next loader ([#102](#102)) ([e0f6651](e0f6651))
@github-actions
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling the loader after google API has failed with x retries should try loading the library again
2 participants