feat: add retries #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 95 110 +15
Branches 19 23 +4
=========================================
+ Hits 95 110 +15
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2020
# [1.10.0](v1.9.0...v1.10.0) (2020-11-13) ### Features * add retries for script.onerror with default of 5 retry attempts ([#99](#99)) ([4c5eac0](4c5eac0))
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
louisnow
reviewed
Nov 14, 2020
| private loadErrorCallback(e: Event): void { | ||
| this.onerrorEvent = e; | ||
| this.callback(); | ||
| deleteScript(): void { |
There was a problem hiding this comment.
@jpoehnelt While working on #102 I noticed this deleteScript function wasn't marked private. Was this intentional, is it a public facing API? I can update the docs if so. :)
timhwang21
added a commit
to timhwang21/google-map-react
that referenced
this pull request
Mar 8, 2022
There are some nice changes since 1.7.0: - googlemaps/js-api-loader#99 -- retries loading the Google Maps script (which is a common source of error reports) - googlemaps/js-api-loader#351 -- fixes bad promise rejection that was reported by a user of google-maps-react It's a fairly big version bump but the vast majority of changes are dev dependency bumps.
itsmichaeldiego
pushed a commit
to google-map-react/google-map-react
that referenced
this pull request
Sep 6, 2022
There are some nice changes since 1.7.0: - googlemaps/js-api-loader#99 -- retries loading the Google Maps script (which is a common source of error reports) - googlemaps/js-api-loader#351 -- fixes bad promise rejection that was reported by a user of google-maps-react It's a fairly big version bump but the vast majority of changes are dev dependency bumps.
AMagicHarry
added a commit
to AMagicHarry/google-map-react
that referenced
this pull request
Mar 12, 2024
There are some nice changes since 1.7.0: - googlemaps/js-api-loader#99 -- retries loading the Google Maps script (which is a common source of error reports) - googlemaps/js-api-loader#351 -- fixes bad promise rejection that was reported by a user of google-maps-react It's a fairly big version bump but the vast majority of changes are dev dependency bumps.
Hunter0116
added a commit
to Hunter0116/google-map-react
that referenced
this pull request
May 26, 2024
There are some nice changes since 1.7.0: - googlemaps/js-api-loader#99 -- retries loading the Google Maps script (which is a common source of error reports) - googlemaps/js-api-loader#351 -- fixes bad promise rejection that was reported by a user of google-maps-react It's a fairly big version bump but the vast majority of changes are dev dependency bumps.
justinsand0713
added a commit
to justinsand0713/google-map-react
that referenced
this pull request
May 26, 2024
There are some nice changes since 1.7.0: - googlemaps/js-api-loader#99 -- retries loading the Google Maps script (which is a common source of error reports) - googlemaps/js-api-loader#351 -- fixes bad promise rejection that was reported by a user of google-maps-react It's a fairly big version bump but the vast majority of changes are dev dependency bumps.
LegendaryNaix
added a commit
to LegendaryNaix/google-map-react
that referenced
this pull request
May 29, 2024
There are some nice changes since 1.7.0: - googlemaps/js-api-loader#99 -- retries loading the Google Maps script (which is a common source of error reports) - googlemaps/js-api-loader#351 -- fixes bad promise rejection that was reported by a user of google-maps-react It's a fairly big version bump but the vast majority of changes are dev dependency bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The singleton loader will retry on script failures up to
retriesattempts. A new instance will not retry again.closes #93