chore(ci): run tests on both amd64 and arm64 #3889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
changed the title
kolesnikovae
force-pushed
the
chore/ci-test-multiarch
branch
from
8be1d3a to
412607f
Compare
|
I think we can remove |
kolesnikovae
force-pushed
the
chore/ci-test-multiarch
branch
from
5fa7bb6 to
71faf6c
Compare
kolesnikovae
force-pushed
the
chore/ci-test-multiarch
branch
from
121fb6f to
544761c
Compare
kolesnikovae
commented
Feb 5, 2025
Comment on lines
+37
to
+38
| - name: Install node-canvas | ||
| run: sudo apt-get update && sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev |
There was a problem hiding this comment.
This is for cypress, not our frontend. This is not required for amd64, but I added it there as well just in case – frankly, it doesn't matter what exactly version of canvas we use in cypress, but I think it's better to keep steps identical
kolesnikovae
changed the title
korniltsev
approved these changes
Feb 5, 2025
simonswine
approved these changes
Feb 5, 2025
.github/workflows/e2e.yaml
Outdated
Comment on lines
20
to
23
| - arch: amd64 | ||
| runner: ubuntu-latest | ||
| - arch: arm64 | ||
| runner: github-hosted-ubuntu-arm64 |
There was a problem hiding this comment.
According to this https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ this image might be free/cheaper
Suggested change
| - arch: amd64 | |
| runner: ubuntu-latest | |
| - arch: arm64 | |
| runner: github-hosted-ubuntu-arm64 | |
| - arch: amd64 | |
| runner: ubuntu-24.04 | |
| - arch: arm64 | |
| runner: ubuntu-24.04-arm |
There was a problem hiding this comment.
TIL Azure Cobalt 100
kolesnikovae
force-pushed
the
chore/ci-test-multiarch
branch
from
5091c21 to
3f565dd
Compare
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
* run tests on both amd64 and arm64 * use ubuntu-24.04 runners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regular pathonly. The canvas library cypress depends on is not released forlinux/arm64, so I had to add some dependencies.linux/amd64. As long as we don't have arch-dependent code, this is fine. Let me know if you want to enable linting for arm64 as well.Resolves #3880