Skip to content

chore(ci): run tests on both amd64 and arm64 #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolesnikovae merged 2 commits into from
Feb 6, 2025
Merged

chore(ci): run tests on both amd64 and arm64 #3889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544761c
run tests on both amd64 and arm64
kolesnikovae Feb 5, 2025
3f565dd
use ubuntu-24.04 runners
kolesnikovae Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,14 @@ concurrency:

jobs:
regular-path:
runs-on: ubuntu-latest
strategy:
matrix:
include:
- arch: amd64
runner: ubuntu-24.04
- arch: arm64
runner: ubuntu-24.04-arm
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -27,10 +34,11 @@ jobs:
with:
go-version: "1.22.11"
cache: true
- run: yarn --frozen-lockfile
- name: Install node-canvas
run: sudo apt-get update && sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
Comment on lines +37 to +38
Copy link
Collaborator Author

@kolesnikovae kolesnikovae Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for cypress, not our frontend. This is not required for amd64, but I added it there as well just in case – frankly, it doesn't matter what exactly version of canvas we use in cypress, but I think it's better to keep steps identical

- run: make build
- name: Cypress run
uses: cypress-io/github-action@v5
uses: cypress-io/github-action@v6
with:
wait-on: http://localhost:4040/ready
start: make run
Expand All @@ -57,12 +65,13 @@ jobs:
with:
go-version: "1.22.11"
cache: true
- run: yarn --frozen-lockfile
- name: Install node-canvas
run: sudo apt-get update && sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
- run: make build
- name: run nginx with /foobar/
run: docker compose -f scripts/base-url/docker-compose.yaml up -d
- name: Cypress run
uses: cypress-io/github-action@v5
uses: cypress-io/github-action@v6
with:
wait-on: http://localhost:8080/foobar/ready
start: |
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,14 @@ jobs:
- name: Check generated files
run: make generate check/unstaged-changes
test:
runs-on: ubuntu-latest
strategy:
matrix:
include:
- arch: amd64
runner: ubuntu-24.04
- arch: arm64
runner: ubuntu-24.04-arm
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
Loading