Skip to content

Fix nil panic in UniqueOperationNamesRule with two anonymous operations #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix nil panic in UniqueOperationNamesRule with two anonymous operations #147

wants to merge 1 commit into from

Conversation

titanous
Copy link
Contributor

node.Name is nil when the operation is anonymous. Use the parent AST node instead in this case.

Found with go-fuzz.

@titanous
Fix nil panic in UniqueOperationNamesRule with two anonymous operations
ab875bc 
node.Name is nil when the operation is anonymous. Use the parent AST
node instead in this case.

Found with go-fuzz.

Signed-off-by: Jonathan Rudenberg <[email protected]>
@coveralls
Copy link

coveralls commented Jul 18, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 90.762% when pulling ab875bc on titanous:fix-unique-name-nil into 491504a on graphql-go:master.

@titanous titanous mentioned this pull request Aug 13, 2016
Closed
@chris-ramon chris-ramon mentioned this pull request Aug 5, 2017
Merged
1 task
@chris-ramon
Copy link
Member

closing this one in favor of #224 — thanks a lot @titanous

@chris-ramon chris-ramon closed this Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titanous @coveralls @chris-ramon