Skip to content

language/parser: Fix infinite loop on unexpected character #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Jul 20, 2016

This PR was previously submitted by @titanous on: #149

Ensure errors returned by the lexer are returned by any().

Hang found by go-fuzz.

Ensure errors returned by the lexer are returned by any().

Hang found by go-fuzz.

Signed-off-by: Jonathan Rudenberg <[email protected]>
@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage remained the same at 90.754% when pulling a8b0417 on titanous/fix-parse-hang into 491504a on master.

@chris-ramon
Copy link
Member Author

let's merge previous PR's, in order to avoid git conflicts if possible.

@chris-ramon
Copy link
Member Author

LGTM, thanks again @titanous

@titanous
Copy link
Contributor

Is there a specific PR that you think will conflict with this one?

@chris-ramon
Copy link
Member Author

Is there a specific PR that you think will conflict with this one?

yes, for example PR: #47 would, ideally we want to merge #47 first.

@titanous
Copy link
Contributor

What's blocking merging this, #152, and #147?

@chris-ramon chris-ramon deleted the titanous/fix-parse-hang branch July 23, 2017 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants