Updating graphql-spring-boot to use graphql-java:15. #461
Conversation
…ease of graphql-java-servlet (graphql-java-kickstart/graphql-java-servlet#269)
|
I'm afraid, this is not so easy:) GraphQL Java 15 (https://github.com/graphql-java/graphql-java/releases/tag/v15.0) has some breaking changes as well as new features, that should be properly integrated. The heavy lifting, I guess, is largely done in https://github.com/graphql-java-kickstart/graphql-java-tools. I see there is an aptly named branch there (https://github.com/graphql-java-kickstart/graphql-java-tools/tree/405-upgrade-to-graphql-java-15), but without commits. Perhaps @vojtapol can tell more about the status/progress of this feature. As for the recently added GraphQL Annotations support, it is also on GraphQL Java 14 and can only be upgraded once the GraphQL Java Annotations library itself is updated. |
|
@BlasiusSecundus - thanks for taking the time to reply. Maybe I'm missing something, but locally with the updates in graphql-java-kickstart/graphql-java-servlet#270 and in this PR, all of the modules compiled, all tests passed and my GraphQL SpringBoot services (~10) functioned as expected. As for graphql-java-tools, release 6.2.0 added graphql-java:15 support https://github.com/graphql-java-kickstart/graphql-java-tools/releases/tag/6.2.0 I did not look into GraphQL Annotations but I can take a look to see how easy that will be. |
|
Yes, you are totally right, java-graphql-tools was already updated, I missed that. |
|
If/when this graphql-java-kickstart/graphql-java-servlet#270 is merged & released, then I'll be able to update this branch for graphql-spring-boot and see the true state of the CI test results |
|
Issue opened for graphql-java-annotations Enigmatis/graphql-java-annotations#259 |
|
Pull Request Enigmatis/graphql-java-annotations#260 |
|
graphql-java-annotations v8.2 has now been released, with support for graphql-java-tools-15.0 https://github.com/Enigmatis/graphql-java-annotations/releases/tag/v8.2 |
|
graphql-java-servlets v10.0.0 has now been released, with support for graphql-java-tools-15.0 |
|
@oliemansm @vojtapol - all the dependent libraries are now graphql-java-15 compatible: Are you able to do a review of this PR and merge/release at your convenience :) |
|
Thanks @setchy ! Once all checks have passed I'll merge it. |
|
@setchy Can't merge it as is unfortunately since there are failing unit tests. First glance I notice something about Scalar Long not found, which rings a bell being mentioned in the release notes of graphql-java 15.0: https://github.com/graphql-java/graphql-java/releases/tag/v15.0. |
thanks @oliemansm - let me look into this. I believe I could address this in a few ways
Do you have a preference? |
|
@setchy By the looks of it that version hasn't been released to maven central yet, see graphql-java/graphql-java-extended-scalars#24. It also pulls in a lot of other scalars of which some might be conflicting (e.g. DateTime) with existing usages. While the DateTime scalar implemented by that library seems lacking functionality compared to https://github.com/donbeave/graphql-java-datetime (see also graphql-java/graphql-java-extended-scalars#7). So considering all that and mainly the maven central sync issue I'd go with your option 2 in the end. |
… being removed from graphql-java-15 and out to graphql-java-extended-scalars (ref https://github.com/graphql-java/graphql-java/releases/tag/v15.0)
…java-15-support' into feature/457-graphql-java-15-support
|
Awesome - by far the easiest path. Should be all sorted now @oliemansm |
|
Thanks @setchy! |
Updating to use graphql-java:15
Releasing graphql-spring-boot will be dependent on the release of the following dependencies
graphql-java-servlet
gradle.propertieswith the final version once releasedgraphql-java-annotations
gradle.propertieswith the final version once released