Skip to content

Proposal: LocalDateTime scalar #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catherinejelder opened this issue Apr 18, 2019 · 13 comments
Closed

Proposal: LocalDateTime scalar #7

catherinejelder opened this issue Apr 18, 2019 · 13 comments

Comments

@catherinejelder
Copy link

We're using a LocalDateTime scalar provided in this project: https://github.com/donbeave/graphql-java-datetime

It would be great if LocalDateTime were provided here.

@bbakerman
Copy link
Member

@catherinejelder - First off apologies for not getting back to you. I have run out of time and this project went onto the back burner and has been neglected.

I agree that LocalDateTime is needed. @andimarek and others have been working on DataTime ideas in the graphql spec working group. So I was holding off in that regard a little.

But mostly the delay on this is from lack of time put towards this project

@Jam3si
Copy link

Jam3si commented Feb 12, 2020

Any update?

@oooplz
Copy link

oooplz commented Jan 7, 2021

Can we support LocalDateTime scalar right now ?

@setchy
Copy link
Contributor

setchy commented Jan 21, 2021

@sseep @Jam3si https://github.com/donbeave/graphql-java-datetime has a rich set of date and time related Scalars that you can leverage

It's what my projects have been using

@setchy
Copy link
Contributor

setchy commented Sep 7, 2021

☝️ me again - there is one key gotcha with graphql-java-datetime, which is its dependency on graphql-java-tools. This doesn't make it a viable option for those using Netflix dgs-framework

having first-class support for LocalDateTime in graphql-java-extended-scalars would be super helpful

@naeul-lee
Copy link

Same here ... !
repeat
"having first-class support for LocalDateTime in graphql-java-extended-scalars would be super helpful"

@ManuelPod
Copy link

I think this could be very nice to add too

@setchy
Copy link
Contributor

setchy commented Nov 12, 2022

https://github.com/tailrocks/graphql-java-datetime now supports

  • Spring GraphQL
  • Netflix DGS
  • GraphQL Java Kickstart

@bhaskar-anil
Copy link

Agree, given it's commonly use, this would be a great addition.
We use this library and also have custom scalar for LocalDateTime, I tried this solution on this repo in my local, and added some tests too. But I can't publish a branch to raise a PR here.

I can add this support to this repo, could moderators pls add me as a contributor/ grant access to publish a branch here.

@setchy
Copy link
Contributor

setchy commented May 27, 2023

@bhaskar-anil, you will need to

  • fork this repository
  • create a branch within your forked repository
  • apply and push your changes to this branch
  • raise a PR for your branch and select this repo as the base

bhaskar-anil added a commit to bhaskar-anil/graphql-java-extended-scalars that referenced this issue May 28, 2023
@bhaskar-anil
Copy link

Hey guys, I have raised a PR yesterday, please review and merge if this looks okay to you guys! Thanks. @setchy

@bhaskar-anil
Copy link

Can anyone please review this PR.

@dondonz
Copy link
Member

dondonz commented Jan 2, 2024

Hello, adding my comment here from another PR #26 (comment)

We'd prefer not to add LocalDateTime to this library as the scalar doesn't include an offset.

Thanks to everyone who contributed to this thread.

@dondonz dondonz closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants