Skip to content

Fix asyncio.wait DeprecationWarning on python 3.9 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leszekhanusz opened this issue Oct 27, 2020 · 1 comment · Fixed by #214
Closed

Fix asyncio.wait DeprecationWarning on python 3.9 #161

leszekhanusz opened this issue Oct 27, 2020 · 1 comment · Fixed by #214
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@leszekhanusz
Copy link
Collaborator

Executing the tests with tox on python 3.9 will generate the following DeprecationWarning:

tests/test_async_client_validation.py: 6 tests with warnings
tests/test_phoenix_channel_exceptions.py: 1 test with warning
tests/test_websocket_exceptions.py: 14 tests with warnings
tests/test_websocket_query.py: 2 tests with warnings
tests/test_websocket_subscription.py: 2 tests with warnings
  /home/leszek/git_repos/gql/.tox/py39-dev/lib/python3.9/site-packages/websockets/server.py:712: DeprecationWarning: The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8, and scheduled for removal in Python 3.11.
    await asyncio.wait(

See Python issue 34790
@leszekhanusz leszekhanusz mentioned this issue Oct 27, 2020
Merged
@leszekhanusz leszekhanusz added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change status: blocked Issues outside of ggl control, caused by dependencies or something else labels Oct 27, 2020
@leszekhanusz
Copy link
Collaborator Author

This is apparently fixed in websockets master.
See issue websockets #762
We will need to wait for the next release of websockets

@leszekhanusz leszekhanusz mentioned this issue Nov 3, 2020
Closed
@leszekhanusz leszekhanusz linked a pull request May 24, 2021 that will close this issue
Bump websockets to 9 #214
Merged
@leszekhanusz leszekhanusz removed the status: blocked Issues outside of ggl control, caused by dependencies or something else label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump websockets to 9 leszekhanusz/gql
1 participant
@leszekhanusz