Skip to content

Release version 9.0 #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leszekhanusz opened this issue Nov 1, 2020 · 15 comments
Closed

Release version 9.0 #845

leszekhanusz opened this issue Nov 1, 2020 · 15 comments

Comments

@leszekhanusz
Copy link

Sorry to be that guy.

The last release was exactly one year ago today. Is there a plan for a new release ?

Thank you.

@aaugustin
Copy link
Member

Hello! Could you clarify which features/bugfixes are currently available in master, but not in the latest releases, and you're missing? Python 3.9 support maybe?

I'm asking because I usually make releases after major features/bugfixes. The only major feature that I remember since the last release is the Sans-I/O interface. it isn't documented (nor used internally) so it's still a private API at this point.

@leszekhanusz
Copy link
Author

This is really nothing much, but yes indeed it is for python 3.9 for the gql package to solve a deprecation warning.
See issue gql #161

@aaugustin
Copy link
Member

OK, thanks for the clarification. Python 3.9 was released less than a month ago, so it's not like the issue lingered for a year.

One of the rare positive side effects of the lockdown is that I tend to have more time for open-source than I would otherwise have. I'll see what I can do.

Making a release would be faster than typing this comment -- git tag 8.2 && git push --tags. However, it requires some availability in case something goes wrong. That's why I usually take time to review what happened since the last release. In this case, a large refactoring happened.

@aaugustin
Copy link
Member

Good to see a non-crypto use of websockets, BTW :-) This gives me a bit of faith in the usefulness of this project!

@adriansev
Copy link

Good to see a non-crypto use of websockets, BTW :-) This gives me a bit of faith in the usefulness of this project!

well, you can be assured that is really useful .. see https://github.com/adriansev/jalien_py (where ALICE means this )

@aaugustin
Copy link
Member

Whoa Adrian I had no idea that's how you used websockets, pretty cool!

@leszekhanusz
Copy link
Author

Good to see a non-crypto use of websockets, BTW :-) This gives me a bit of faith in the usefulness of this project!

well, you can be assured that is really useful .. see https://github.com/adriansev/jalien_py (where ALICE means this )

I can assure you that it is very useful for me as well, even if it is not LHC level 😄 (it will be used for remote maintenance of thousands of buses and trams communication systems)

And with 3k stars on GitHub, I am sure this library is certainly useful to a lot of other people!

I just ran our test suite against the websockets master branch and everything seems to work after I modified our code to import HeadersLike from websockets.datastructures instead of websockets.http.

There is just another new deprecation warning which appeared:

/home/leszek/miniconda3/envs/gql-dev/lib/python3.8/site-packages/websockets/framing.py:27: DeprecationWarning: websockets.framing is deprecated
    warnings.warn("websockets.framing is deprecated", DeprecationWarning)

See the tests on my testing_new_websockets branch if you are interested

@aaugustin
Copy link
Member

Yes there was a bit of API churn in master due to the Sans-I/O refactor.

See https://github.com/aaugustin/websockets/blob/master/docs/changelog.rst#90

@aaugustin
Copy link
Member

Fun fact: I started websockets because WebSocket looked like a reasonable protocol for talking with stationary batteries at a company that also did electric buses and trams. I left that job shortly thereafter and never used websockets for anything serious but I'm still maintaining it. Your usage of websockets to talk to buses and trams sort of goes full circle :-)

@aaugustin
Copy link
Member

Looking at what you wrote, I should make types like HeadersLike public APIs.

@aaugustin aaugustin changed the title New release Release version 9.0 Nov 21, 2020
@aaugustin
Copy link
Member

So I'm starting to go through issues and figure out what I want to put in 9.0.

I may want to include a "sync" version (i.e. based on socket + threading) which is likely the easiest way to prove that the Sans-I/O version serves a purpose.

@aaugustin
Copy link
Member

At this point the most likely ETA looks like "EOY 2020".

@johnthagen
Copy link

johnthagen commented Apr 28, 2021

Any update on this in 2021?

It would be great to have a release that included wheels for Python 3.9.

@aaugustin
Copy link
Member

The situation is a bit tricky due to the library being in the middle of a huge refactoring and $DAY_JOB leaving very little free time for open source work :-/

I was on holidays last week and did a bit of work on the documentation that was a prerequisite for a release.

aaugustin added a commit that referenced this issue May 1, 2021
@aaugustin
Copy link
Member

https://pypi.org/project/websockets/9.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants