Skip to content

Types used in type annotations for public APIs must be public APIs #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aaugustin opened this issue Nov 21, 2020 · 1 comment
Closed

Types used in type annotations for public APIs must be public APIs #854

aaugustin opened this issue Nov 21, 2020 · 1 comment
Labels
documentation

Comments

@aaugustin
Copy link
Member

In #845 we observed that HeadersLike was a private API but perhaps should be public.

I believe the underlying principle is -- type annotations are part of the public API, therefore all types used in annotation of public APIs should be public APIs.
aaugustin added a commit that referenced this issue May 1, 2021
@aaugustin
Make HeadersLike a public API.
c000260 
Refs #845, #854.
@aaugustin
Copy link
Member Author

I didn't spot any other instances of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaugustin