Skip to content

chore: stable Python 3.9 support #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

KingDarBoja
Copy link
Contributor

GH Actions supports Python 3.9 as stable release. More info: actions/runner-images#1740

@KingDarBoja KingDarBoja added the type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation label Oct 26, 2020
@KingDarBoja KingDarBoja self-assigned this Oct 26, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          929       929           
=========================================
  Hits           929       929           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7765c7...84099b8. Read the comment docs.

@leszekhanusz
Copy link
Collaborator

LGTM 🚀

Actually the test with 3.9-dev never worked on my machine using tox (with conda) on my machine and this change does not solve this.

I could finally test it by adding:

conda_channels =                                                                                                        
    conda-forge

in the [testenv] section of tox.ini

Maybe we should add this to the CONTRIBUTING.md file

During testing I discovered that there are deprecation warnings under python3.9 and created issue #161

@KingDarBoja
Copy link
Contributor Author

KingDarBoja commented Oct 27, 2020

@leszekhanusz looks like it is still not available on default, but it does on conda-forge or anaconda channels: https://anaconda.org/anaconda/python

Maybe we should add this to the CONTRIBUTING.md file

Yeah, while the Python version is supported by default, I will add it to the tox.ini file in this PR.

During testing I discovered that there are deprecation warnings under python3.9 and created issue

I ignored those while running py3.9-dev locally 😆 but glad you made a PR for that.

@KingDarBoja KingDarBoja merged commit d9788dd into graphql-python:master Oct 27, 2020
@KingDarBoja KingDarBoja deleted the py39-full-support branch October 27, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants