Skip to content

[documentation] Fix Connection patterns #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented Feb 12, 2020

In most cases, it is not recommended to create custom connection classes since it can conflict with the ones auto-created by SQLAlchemyObjectType. This should prevent a lot of confusion: #153, #65

If needed, it's possible to access the auto-created connections like this: PetType.connection

This also updates tests to keep things consistent.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.531% when pulling f089930 on jnak:clean-doc into 6dca279 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.531% when pulling f089930 on jnak:clean-doc into 6dca279 on graphql-python:master.

@jnak jnak merged commit 4c5b4d1 into graphql-python:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants