Skip to content

Latest Graphene (v3.0.0) is incompatible with latest gql (v3.0.0) #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serramatutu opened this issue Feb 9, 2022 · 7 comments
Closed
Labels

Comments

@serramatutu
Copy link

serramatutu commented Feb 9, 2022

Current behavior

Current Graphene (v3.0.0) and GQL (v3.0.0) packages are incompatible due to no overlap between specified graphql-core versions.

If you try to install both using a package manager with a dependency resolver such as Poetry, it'll break.

Demo project or reproducible steps

There's no need for a demo project. Here are the minimal steps to reproduce the problem:

  1. Create an empty folder
  2. Run poetry init
  3. Run poetry add graphene
  4. Run poetry add gql.
  5. It'll break and complain graphql-core package versions are incompatible.

What is the expected behavior?

Graphene and GQL should be installable together

Use case/motivation

It'd be nice if both packages worked well together.

My environment

  • Version: 3.0.0
  • Platform: Ubuntu 20.04 LTS

Other info

Graphene specifies graphql-core~=3.1.2 while GQL specifies graphql-core>=3.2,<3.3. There are obviously no overlapping versions.
I suggest bumping the graphql-core version.

Screenshots

image
image

@serramatutu serramatutu changed the title Latest Graphene (v3.0.0) is incompatible with gql (v3.0.0) are incompatible Latest Graphene (v3.0.0) is incompatible with gql (v3.0.0) Feb 16, 2022
@serramatutu serramatutu changed the title Latest Graphene (v3.0.0) is incompatible with gql (v3.0.0) Latest Graphene (v3.0.0) is incompatible with latest gql (v3.0.0) Feb 16, 2022
@ddelange
Copy link

ddelange commented Apr 4, 2022

FYI our current workaround is to pin to a gql release candidate:

graphene==3.0 (3.0)
├── aniso8601<10,>=8 (9.0.1)
├── graphql-core~=3.1.2 (3.1.7)
└── graphql-relay<4,>=3.0 (3.1.5)
    └── graphql-core<3.2,>=3.1 (3.1.7)
gql==3.0.0rc0 (3.0.0rc0)
├── graphql-core<3.2,>=3.1.5 (3.1.7)
└── yarl<2.0,>=1.6 (1.7.2)
    ├── idna>=2.0 (3.3)
    └── multidict>=4.0 (6.0.2)

@serramatutu
Copy link
Author

@ddelange As a workaround, I vendored dependencies in the Dockerfile and added the import paths to be from vendor.gql.gql import .... So I effectively installed 2 different versions of GQL.

@rexledesma
Copy link

Looks like this should beresolved with #1421!! Do you know when we should expect a new release of graphene with this change?

@ddelange
Copy link

ddelange commented May 25, 2022

Looks like this should beresolved with #1421!! Do you know when we should expect a new release of graphene with this change?

pinging @Cito for this question

indeed it looks resolved btw :)

$ pipgrip --tree gql graphene@git+https://github.com/graphql-python/graphene.git@9c3e4bb
gql (3.3.0)
├── graphql-core<3.3,>=3.2 (3.2.1)
└── yarl<2.0,>=1.6 (1.7.2)
    ├── idna>=2.0 (3.3)
    └── multidict>=4.0 (6.0.2)
graphene@ git+https://github.com/graphql-python/graphene.git@9c3e4bb (git+https://github.com/graphql-python/graphene.git@9c3e4bb)
├── aniso8601<10,>=8 (9.0.1)
├── graphql-core<3.3,>=3.1 (3.2.1)
└── graphql-relay<3.3,>=3.1 (3.2.0)
    └── graphql-core<3.3,>=3.2 (3.2.1)

@Cito
Copy link
Member

Cito commented May 25, 2022

@ddelange Yes, I think this is resolved. But I'm not a Graphene maintainer and currently don't use it actively. I have passed the question on to the Graphene slack channel.

@richin13
Copy link

Pinging @mvanlonden since he was able to help with releases in the past! 🙏🏼

@jkimbo
Copy link
Member

jkimbo commented May 30, 2022

Published a new release v3.1.0. New release should be on pypi shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants