-
Notifications
You must be signed in to change notification settings - Fork 184
Bump graphql-core to 3.2.0 #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump graphql-core to 3.2.0 #283
Conversation
…contain [_a-zA-Z0-9] but 'meta-field' does not.'
Fixes 'Support for returning GraphQLObjectType from resolve_type was removed in GraphQL-core 3.2, please return type name instead'
…te 'enter_leave_map'
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2060 2060
=========================================
Hits 2060 2060
Continue to review full report at Codecov.
|
@Cito |
If everything is working fine with the 3.2 rc3 version, then I think it's ok - 3,2 final will be released soon and will not have breaking changes. |
This new version of GraphQL-core replaces the FrozenLists in AST nodes with tuples, so we need to make the appropriate changes in dsl.py.
Sorry, there was a 3.2 rc4 version, and contrary to what I promised above, it contained one breaking change. To make up for this, I have already updated this PR with the necessary fixes. And this should really be the last breaking change before 3.2 final. |
No worries, keep up the good work! |
Does this PR drop support for Edit: I asked too soon, looks from comments above it is definitely breaking 😅 |
No description provided.