ScalarType: is there any purpose for renaming option specifiedByUrl (15.x) to specifiedByURL (16.x)? It affects on GraphQLJSON and other scalars distributed via npm
#3156
Comments
|
@saihaj thanks for the reference. I think that @IvanGoncharov made a typo in his comment with |
|
If you check the spec PR it is |
leszekhanusz
added a commit
to leszekhanusz/gql
that referenced
this issue
Dec 13, 2021
leszekhanusz
added a commit
to graphql-python/gql
that referenced
this issue
Jan 16, 2022
* Fix error 'graphql.error.graphql_error.GraphQLError: Names must only contain [_a-zA-Z0-9] but 'meta-field' does not.' * Don't use format_error * Put the is_finite method in the test file * Fix StarWars schema Fixes 'Support for returning GraphQLObjectType from resolve_type was removed in GraphQL-core 3.2, please return type name instead' * fix print_ast removing last newline * Fix error: AttributeError: 'ParseResultVisitor' object has no attribute 'enter_leave_map' * Rename specifiedByUrl to specifiedByURL See graphql/graphql-js#3156 * Bump graphql-core version to stable 3.2 This new version of GraphQL-core replaces the FrozenLists in AST nodes with tuples, so we need to make the appropriate changes in dsl.py. * Fix Introspection directive typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there any purpose that in v16 was renamed the following property:
export class GraphQLScalarType { name: string; description: Maybe<string>; - specifiedByUrl: Maybe<string>; + specifiedByURL: Maybe<string>;v15.5 https://github.com/graphql/graphql-js/blob/15.x.x/src/type/definition.js#L578
v16.0.0-alpha.2 https://github.com/graphql/graphql-js/blob/main/src/type/definition.ts#L580
This change breaks
specifiedByUrldefinition for Scalars distributed via npm. Most popular is GraphQLJSON: https://github.com/taion/graphql-type-json/blob/master/src/index.js#L55-L56The text was updated successfully, but these errors were encountered: