-
Notifications
You must be signed in to change notification settings - Fork 187
[Compat, Build] Only link Boost::System if Boost < 1.89 #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compat, Build] Only link Boost::System if Boost < 1.89 #2823
Conversation
…9 - Boost 1.89 mad Boost System header-only
jamescowens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
994343a
into
gridcoin-community:development
|
After I merged this, I realize it doesn't work. The second call to AX_BOOST_BASE doesn't do what the author thinks. It actually resets the minimum library version requirements to 1.89 and cause a failure with BOOST < 1.89. copying packages: native_ccache boost openssl curl zlib libzip qrencode qt miniupnpc |
|
That's odd, I could have sworn it worked on my end... I'll take another look, my bad |
|
I can confirm, that running locally this configures correctly, with both Boost 1.69 and 1.89. The only thing I can think of is that Ubuntu Jammy includes autoconf 2.71 and m4 1.4.18, while I'm running 2.72 and 1.4.20 respectively. Something might have changed there. |
|
I fixed it. Slightly different than your original approach. I also added a fallback data source from my AWS S3 source bucket, since we are still dependent on some things that Bitcoin no longer provides backup sources for (such as Qt 5.15, which we need to move off of). |
In Boost = 1.89, the Boost::System library was made header only. While this is currently only an issue with Arch and other rolling distros, it will become a problem at some point in the future. As such, I've modified configure.ac to only try and link against Boost::System if Boost < 1.89
This issue does not seem to occur on Linux when using Cmake.