Skip to content

Conversation

@jamescowens
Copy link
Member

@jamescowens jamescowens commented Nov 14, 2025

This is a fix for #2823. It also adds multiple fallback source capability for depends source file downloads. The current secondary fallback is set to the project lead's AWS S3 source bucket.

Closes #2820.

@jamescowens jamescowens self-assigned this Nov 14, 2025
@jamescowens jamescowens added this to the Natasha milestone Nov 14, 2025
@jamescowens jamescowens force-pushed the fix_boost_1.89+configure.ac branch 10 times, most recently from f9a3ebf to 9d9a9dc Compare November 15, 2025 23:52
@jamescowens jamescowens changed the title Fix configure.ac changes for boost >1.89 build: Add multiple depends source fallback capability and Fix configure.ac changes for boost >1.89 Nov 16, 2025
@jamescowens jamescowens changed the title build: Add multiple depends source fallback capability and Fix configure.ac changes for boost >1.89 build: Add multiple depends source fallback capability and Fix configure.ac changes for boost >=1.89 Nov 16, 2025
@jamescowens jamescowens requested a review from Copilot November 16, 2025 00:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades Boost from version 1.81.0 to 1.89.0 and adds a multiple fallback source capability for the depends build system to improve reliability when downloading dependency source files.

  • Boost library upgraded from 1.81.0 to 1.89.0 with corresponding SHA256 hash update
  • Multiple fallback download paths implemented for source file downloads
  • Fixed configure.ac logic to properly detect Boost.System as header-only in Boost >= 1.89.0

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
depends/packages/boost.mk Updates Boost version to 1.89.0 and SHA256 hash for the new version
depends/funcs.mk Implements multiple fallback URL support in the fetch_file function with improved error messaging
depends/Makefile Defines FALLBACK_DOWNLOAD_PATHS with primary and secondary fallback sources, and adds unused DOWNLOAD variable definition
configure.ac Refactors Boost.System header-only detection logic for compatibility with Boost >= 1.89.0 (though formatting needs improvement)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamescowens jamescowens force-pushed the fix_boost_1.89+configure.ac branch from 75e6ce7 to 676a48a Compare November 16, 2025 01:42
@jamescowens jamescowens marked this pull request as ready for review November 16, 2025 02:30
@jamescowens jamescowens merged commit 67cb62c into gridcoin-community:development Nov 16, 2025
25 checks passed
@jamescowens
Copy link
Member Author

Note that the 1.89+ boost fix was verified by first doing CI against boost <1.89 (1.81 was in the original boost.mk package), and then incrementing boost to 1.89 in a new commit, and then checking CI again. All passed.

@jamescowens
Copy link
Member Author

jamescowens commented Nov 17, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compile/make failure (many errors)

1 participant