-
Notifications
You must be signed in to change notification settings - Fork 187
build: Add multiple depends source fallback capability and Fix configure.ac changes for boost >=1.89 #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add multiple depends source fallback capability and Fix configure.ac changes for boost >=1.89 #2824
Conversation
f9a3ebf to
9d9a9dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request upgrades Boost from version 1.81.0 to 1.89.0 and adds a multiple fallback source capability for the depends build system to improve reliability when downloading dependency source files.
- Boost library upgraded from 1.81.0 to 1.89.0 with corresponding SHA256 hash update
- Multiple fallback download paths implemented for source file downloads
- Fixed configure.ac logic to properly detect Boost.System as header-only in Boost >= 1.89.0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| depends/packages/boost.mk | Updates Boost version to 1.89.0 and SHA256 hash for the new version |
| depends/funcs.mk | Implements multiple fallback URL support in the fetch_file function with improved error messaging |
| depends/Makefile | Defines FALLBACK_DOWNLOAD_PATHS with primary and secondary fallback sources, and adds unused DOWNLOAD variable definition |
| configure.ac | Refactors Boost.System header-only detection logic for compatibility with Boost >= 1.89.0 (though formatting needs improvement) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The second fallback is now set to the lead dev's source bucket hosted by AWS S3.
75e6ce7 to
676a48a
Compare
|
Note that the 1.89+ boost fix was verified by first doing CI against boost <1.89 (1.81 was in the original boost.mk package), and then incrementing boost to 1.89 in a new commit, and then checking CI again. All passed. |
|
We are ahead of many coins but we are definitely a little behind Bitcoin Core in updating the depends side of the build system and getting Qt6 done there. Bitcoin Core has had a significant amount of activity this year.Sent from my iPhoneOn Nov 17, 2025, at 12:37 PM, Xeno345 ***@***.***> wrote:Xeno345 left a comment (gridcoin-community/Gridcoin-Research#2824)
Les autre crypto populaire font aussi clés changement ? Cela est récent ou Gridcoin est en retard un peu ?
Téléchargez Outlook pour iOS<https://aka.ms/o0ukef>
…________________________________
De : James C. Owens ***@***.***>
Envoyé : Sunday, November 16, 2025 10:51:51 AM
À : gridcoin-community/Gridcoin-Research ***@***.***>
Cc : Subscribed ***@***.***>
Objet : Re: [gridcoin-community/Gridcoin-Research] build: Add multiple depends source fallback capability and Fix configure.ac changes for boost >=1.89 (PR #2824)
[https://avatars.githubusercontent.com/u/7529186?s=20&v=4]jamescowens left a comment (gridcoin-community/Gridcoin-Research#2824)<#2824 (comment)>
Note that the 1.89+ boost fix was verified by first doing CI against boost <1.89 (1.81 was in the original boost.mk package), and then incrementing boost to 1.89 in a new commit, and then checking CI again. All passed.
—
Reply to this email directly, view it on GitHub<#2824 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BSXDQE6GRTH23ROSBDLDPA335CMRPAVCNFSM6AAAAACMFA2BO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMZYHA4TCOJWGQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
This is a fix for #2823. It also adds multiple fallback source capability for depends source file downloads. The current secondary fallback is set to the project lead's AWS S3 source bucket.
Closes #2820.