Skip to content

Fixes #2247. Preparing for the NStack v1.0.7 which now handling properly non-BMP code points. #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Dec 5, 2022

Fixes #2247 - There is still needed to fix non-BMP for the WindowsDriver and CursesDriver. For this to work is needed to install the NStack v1.0.7 which can now be published.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
Copy link
Collaborator

tig commented Dec 5, 2022

@BDisp this PR fails to build.

@BDisp
Copy link
Collaborator Author

BDisp commented Dec 5, 2022

@BDisp this PR fails to build.

Because I couldn't update to the NStack v1.0.7 yet. You must republish it first.

@tig tig merged commit 0efdec3 into gui-cs:develop Dec 6, 2022
@BDisp BDisp deleted the non-bmp-fix-2247 branch December 6, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing for the NStack v1.0.7 which now handling properly non-BMP code points.
2 participants