-
-
Notifications
You must be signed in to change notification settings - Fork 844
Removed Judy Lee's leadership variable #8021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Judy Lee's leadership variable #8021
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 10 AM 4/1/25 |
|
Review ETA: 6 PM 02/04/25 |
melissaluc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Visual change matches issue description
LRenDO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xnealcarson!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Changes appear correctly on the site. Judy Lee has been removed.
- Relevant images were included to show visual changes
- The PR request clearly states what was updated
- The PR request states why the changes are being made
Recommendation for the future: Check off the boxes in the original issue once they are complete.
Again, nice work and thanks for taking the time to contribute to the website!
|
Hi @TheManTheMythTheGameDev and @kdaca19xx! I went ahead and merged this tonight. It would be great if you could review #8039. If you're up for it you can go ahead and take yourself off of this PR and add yourself as reviewers over there. Thanks! |
Fixes #7469
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied