Skip to content

Conversation

@xnealcarson
Copy link
Member

Fixes #7469

What changes did you make?

  • Removed Judy Lee from the 'leadership' variable of the _projects/vrms.md file

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Before

Visuals after changes are applied

After

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b xnealcarson-update-project-profile-7469 gh-pages
git pull https://github.com/xnealcarson/website.git update-project-profile-7469

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 29, 2025
@mugdhchauhan mugdhchauhan requested a review from melissaluc March 30, 2025 17:10
@kdaca19xx kdaca19xx self-requested a review March 30, 2025 17:21
@TheManTheMythTheGameDev
Copy link
Member

Review ETA: 10 AM 4/1/25
Availability: 9-11 AM Weekdays

@melissaluc
Copy link
Member

melissaluc commented Apr 1, 2025

Review ETA: 6 PM 02/04/25
Availability: 9 - 7 PM Wednesday

Copy link
Member

@melissaluc melissaluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Visual change matches issue description

@LRenDO LRenDO self-requested a review April 3, 2025 06:21
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xnealcarson!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site. Judy Lee has been removed.
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Recommendation for the future: Check off the boxes in the original issue once they are complete.

Again, nice work and thanks for taking the time to contribute to the website!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Apr 3, 2025
@LRenDO LRenDO merged commit 19f7fe8 into hackforla:gh-pages Apr 3, 2025
7 checks passed
@LRenDO
Copy link
Member

LRenDO commented Apr 3, 2025

Hi @TheManTheMythTheGameDev and @kdaca19xx! I went ahead and merged this tonight. It would be great if you could review #8039. If you're up for it you can go ahead and take yourself off of this PR and add yourself as reviewers over there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Remove Judy Lee

4 participants