-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Project Profile: Expunge Assist Remove Analicia Mejia Mesinas #8039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Expunge Assist Remove Analicia Mejia Mesinas #8039
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
xnealcarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present: 'Fixes #7487'.
- The changes made are applicable and clean.
- Changes were viewable in browser.
Great job completing your issue, Owais!
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to go, Owais!
Things Done Awesomely
-
Is the pull request done with the correct branch? Yes.
-
Is there a linked issue? Yes.
-
I understand the issue as a webpage update task.
-
I took a look at the "files changed" tab, and I viewed the changes in the browser.
Suggested Changes
- n/a
dvernon5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @owaisjunedi
Thank you for taking this issue and your hard work. I do not have any new input that the other reviewers already stated.
Your Title name and explanations are strong. Your PR contains the correct branch name. You successfully linked your issues. Furthermore, you completed your assignment, the changes are present locally in the codebase and on the webpage. Your images are presented clearly.
I will approve this PR. Excellent job!!
Fixes #7487
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied