Skip to content

Conversation

@owaisjunedi
Copy link
Member

@owaisjunedi owaisjunedi commented Apr 3, 2025

Fixes #7487

What changes did you make?

  • Removed "Analicia Mejia Mesinas" information from the Expunge Assist Project File.

Why did you make the changes (we will use this info to test)?

  • To keep the project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Capture - Before

Visuals after changes are applied

Capture - After

@github-actions
Copy link

github-actions bot commented Apr 3, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b owaisjunedi-update-project-profile-7487 gh-pages
git pull https://github.com/owaisjunedi/website.git update-project-profile-7487

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 3, 2025
@owaisjunedi owaisjunedi self-assigned this Apr 4, 2025
@owaisjunedi owaisjunedi requested review from dvernon5, jackyuan1, kdaca19xx and xnealcarson and removed request for kdaca19xx and xnealcarson April 5, 2025 19:55
Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things Done Well

  • The issue has the correct 'commit into': "hackforla:gh-pages".
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present: 'Fixes #7487'.
  • The changes made are applicable and clean.
  • Changes were viewable in browser.

Great job completing your issue, Owais!

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go, Owais!

Things Done Awesomely

  • Is the pull request done with the correct branch? Yes.

  • Is there a linked issue? Yes.

  • I understand the issue as a webpage update task.

  • I took a look at the "files changed" tab, and I viewed the changes in the browser.

Suggested Changes

  • n/a

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Apr 6, 2025
Copy link
Member

@dvernon5 dvernon5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @owaisjunedi 



Thank you for taking this issue and your hard work.

I do not have any new input that the other reviewers already stated.

Your Title name and explanations are strong. Your PR contains the correct branch name. You successfully linked your issues. Furthermore, you completed your assignment, the changes are present locally in the codebase and on the webpage. Your images are presented clearly. 



I will approve this PR. Excellent job!!

@t-will-gillis t-will-gillis merged commit d4082ef into hackforla:gh-pages Apr 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist Remove Analicia Mejia Mesinas

5 participants