Skip to content

bring back py39#51

Merged
hampsterx merged 1 commit intomasterfrom
feat/add-python-3.9-support
Jun 21, 2025
Merged

bring back py39#51
hampsterx merged 1 commit intomasterfrom
feat/add-python-3.9-support

Conversation

@hampsterx
Copy link
Copy Markdown
Owner

@hampsterx hampsterx commented Jun 21, 2025

resolves #49 mbad~

Summary by CodeRabbit

  • New Features
    • Added support for Python 3.9, including compatibility in testing, documentation badges, and code formatting.
  • Chores
    • Updated project metadata and configuration to reflect support for Python 3.9.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 21, 2025

Walkthrough

The changes expand Python version compatibility from 3.10+ to include Python 3.9 across the project. This includes updates to CI workflows, documentation badges, code formatting configuration, and package metadata to reflect and support Python 3.9 alongside existing supported versions.

Changes

Files/Paths Change Summary
.github/workflows/publish.yml, test.yml Added Python 3.9 to CI test matrix for workflows.
README.md Added Python 3.9 badge for supported Python versions.
pyproject.toml Included 'py39' in Black formatter's target-version configuration.
setup.py Updated classifiers and python_requires to support Python 3.9.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CI
    participant Codebase

    Developer->>CI: Push code/update workflows
    CI->>CI: Run tests on Python 3.9, 3.10, 3.11, 3.12
    CI->>Codebase: Validate compatibility across all versions
    Codebase-->>CI: Test results for each Python version
    CI-->>Developer: Report test outcomes
Loading

Assessment against linked issues

Objective Addressed Explanation
Relax Python version constraint to include >=3.9 (#49)
Update CI and metadata to reflect/support Python 3.9 (#49)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Poem

In the warren, code hops with delight,
Python 3.9 joins the burrow tonight!
Badges shine bright, workflows align,
Black formatter and setup now both opine:
"Welcome, dear 3.9, to our rabbit design!"
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f70c539 and 7b78e02.

📒 Files selected for processing (5)
  • .github/workflows/publish.yml (1 hunks)
  • .github/workflows/test.yml (1 hunks)
  • README.md (1 hunks)
  • pyproject.toml (1 hunks)
  • setup.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: test (3.12)
  • GitHub Check: test (3.11)
  • GitHub Check: test (3.9)
  • GitHub Check: test (3.10)
  • GitHub Check: test-docker
🔇 Additional comments (6)
README.md (1)

3-3: Add Python 3.9 badge: The new badge matches existing styling and correctly links to the Python 3.9 release page, clearly indicating support for 3.9.

.github/workflows/test.yml (1)

14-14: Expand test matrix to include Python 3.9: Adding “3.9” aligns with the PR goal to support Python 3.9. Please verify that all tests pass on Python 3.9.

pyproject.toml (1)

3-3: Update Black target-version to include py39: Including 'py39' ensures code formatting applies correctly for Python 3.9.

setup.py (2)

20-23: Add Python 3.9 to package classifiers: The new "Programming Language :: Python :: 3.9" entry accurately reflects the expanded compatibility.


27-27: Adjust python_requires to >=3.9: Lowering the requirement to >=3.9 aligns with the added support.

.github/workflows/publish.yml (1)

13-13: Include Python 3.9 in publish workflow matrix: Ensures the publish job also validates against Python 3.9.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hampsterx hampsterx merged commit e1e11b2 into master Jun 21, 2025
7 checks passed
@hampsterx hampsterx deleted the feat/add-python-3.9-support branch June 21, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requires-Python >=3.10

1 participant