AppSideNav, SideNav: fix typing issue
#2908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 RC Packages PublishedLatest commit: 112b8b9 |
📦 RC Packages PublishedLatest commit: 112b8b9 |
didoo
reviewed
May 28, 2025
There was a problem hiding this comment.
From a code perspective, everything makes sense (my previous porting to TS was not correct, I see only now)
According to the internal guidance, we should have a changeset associated with the change.
Also, not sure if we should test with at least one consumer (Cloud UI?) to make sure the build works. I'll leave it to you to decide if it's worth it or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would fix an issue with unused arguments being required for the AppSideNav and SideNav components.
🛠️ Detailed description
Currently, the component throws type errors that
@targetis required forHds::AppSideNav/SideNav::Portaland@nameis required forHds::AppSideNav/SideNav::Portal::Target.This is because the types for Portal and Portal::Target are a union of the types from
ember-stargateand our own args. For our components, we expose thetargetNameargument as the way consumers can change the name or target argument.I decided to delete the PortalSignature and PortalTarget signatures entirely because none of those args are passed to the components so if a consumer used them it wouldn't do anything.
Example Hds::AppSideNav::Portal
Notice
@target,@renderInPlace, and@fallbackare not forwarded to thePortalcomponent.handlebars
types
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.