Layout::Flex & Layout::Grid - Prevent inheritance of gap values when nested (HDS-5067)
#2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
commented
Jul 2, 2025
…ts, add zero as a supported value
KristinLBradley
force-pushed
the
kristin/hds-5067-fix-layout-gap-inheritance
branch
from
9a27ecc to
2ac0627
Compare
This comment was marked as outdated.
This comment was marked as outdated.
didoo
force-pushed
the
kristin/hds-5067-fix-layout-gap-inheritance
branch
from
191f3fe to
811cdf3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Cristiano Rastelli <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
didoo
previously approved these changes
Jul 4, 2025
| @@ -8,20 +8,22 @@ | |||
| // | |||
|
|
|||
| .hds-layout-grid { | |||
| // Note: "Unitless 0" <length>s aren’t supported in math functions so we use 0px as a default value within calc() | |||
There was a problem hiding this comment.
[suggestion] maybe add a comment here, explaining why we need to initialize it here (instead of relying on the fallback in the var() declaration), the reason being to avoid being inherited from a parent value.
There was a problem hiding this comment.
I updated the comment with more info
didoo
approved these changes
Jul 8, 2025
3 tasks
zamoore
approved these changes
Jul 8, 2025
Merged
shleewhite
added
release-candidate
📦 RC Packages PublishedLatest commit: ea689a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR fixes a bug in which
gapvalues of nestedFlex&Gridcomponents were being inherited and adds "0" as a supportedgapvalue. Also fixes improper inheritance ofGridcolumnMinWidthvalue.Documentation updates PR: #2998
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.