-
Notifications
You must be signed in to change notification settings - Fork 51
Layout::Flex
& Layout::Grid
- API documentation for gap (HDS-5067)
#2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The base branch was changed.
Fixed merge conflicts |
@KristinLBradley I've pushed a small commit to fix a linting error |
@KristinLBradley I have also removed some duplicate code (probably due to the conflict resolution) |
@KristinLBradley there are extra commits in this PR, coming from https://github.com/hashicorp/design-system/pull/2987/commits. Probably the merge conflicts resolution was not correct: I am going to create a new branch (with the same name), cherry pick only the correct commits, and force push |
3a21616
to
32d64d6
Compare
@KristinLBradley OK, I've force-pushed a clean branch. Can you double check that the commit and the code is what you expect to be? I have also approved, so if that's OK for you, feel free to merge |
@KristinLBradley now that 4.2.11 has been released I think this one can be merged |
📌 Summary
If merged, this PR updates the API documentation for the
Flex
&Grid
componentgap
property. It's a follow-up of #2987Previews:
Component updates PR: #2987 MERGED
🔗 External links
👀 Component checklist
[ ] Percy was checked for any visual regression[ ] A changelog entry was added via Changesets if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.