-
Notifications
You must be signed in to change notification settings - Fork 51
Fix invalid generated CSS (HDS-5314) #3131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled button mixin
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KristinLBradley
commented
Aug 26, 2025
|
||
&::before { | ||
border-color: transparent; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of deleting this style:
::file-selector-button::before
& similar styles no longer exist in the compiled CSS output (packages/components/dist/styles/@hashicorp/design-system-components.css)- There are no Percy diffs
KristinLBradley
commented
Aug 27, 2025
didoo
previously approved these changes
Aug 27, 2025
Co-authored-by: Cristiano Rastelli <[email protected]>
didoo
previously approved these changes
Aug 27, 2025
dchyun
requested changes
Aug 27, 2025
dchyun
approved these changes
Aug 27, 2025
didoo
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR removes/fixes SCSS styles which compile to invalid CSS.
Previews of affected component Showcases:
(See disabled states, no visible changes should be observed)
Button
: https://hds-showcase-git-kristin-hds-5314-fix-invalid-css-hashicorp.vercel.app/components/button#statesDropdown
: https://hds-showcase-git-kristin-hds-5314-fix-invalid-css-hashicorp.vercel.app/components/dropdown#statesFileInput
: https://hds-showcase-git-kristin-hds-5314-fix-invalid-css-hashicorp.vercel.app/components/form/file-input#states🛠️ Detailed description
Where
hds-button-state-disabled
mixin is used:🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.