Skip to content

Fix invalid generated CSS (HDS-5314) #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2025
Merged

Fix invalid generated CSS (HDS-5314) #3131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
10e78bf
HDS-5314 Remove border-color style for before pseudo element from dis…
KristinLBradley Aug 26, 2025
d1d21eb
HDS-5314 Add changeset
KristinLBradley Aug 27, 2025
1697c18
Update mighty-masks-wave.md
KristinLBradley Aug 27, 2025
1a16ab0
Update mighty-masks-wave.md
KristinLBradley Aug 27, 2025
648de19
Apply suggestions from code review
KristinLBradley Aug 27, 2025
290a676
Update mighty-masks-wave.md
KristinLBradley Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changeset/mighty-masks-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@hashicorp/design-system-components": patch
---

<!-- START components/button -->
`Button` - Removed CSS declaration for pseudo element in disabled state
<!-- END -->

<!-- START components/dropdown -->
`Dropdown` - Removed CSS declaration for pseudo element in disabled state
<!-- END -->

<!-- START components/form/file-input -->
`FileInput` - Removed CSS declaration for pseudo element in disabled state that led to invalid CSS (ignored by browsers)
<!-- END -->
4 changes: 0 additions & 4 deletions packages/components/src/styles/mixins/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ $hds-button-size-props: (
border-color: var(--token-color-border-primary);
box-shadow: none;
cursor: not-allowed;

&::before {
border-color: transparent;
}
Copy link
Contributor Author

@KristinLBradley KristinLBradley Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of deleting this style:

  • ::file-selector-button::before & similar styles no longer exist in the compiled CSS output (packages/components/dist/styles/@hashicorp/design-system-components.css)
  • There are no Percy diffs

}

@mixin hds-button-state-focus() {
Expand Down