Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Aug 27, 2025

📌 Summary

If merged, this PR adds support for a cspNonce argument to the Hds::CodeEditor component.

🛠️ Detailed description

The hds-code-editor modifier already supports this nonce attribute, but it wasn't being passed from the component to the modifier.

🔗 External links

Jira ticket: HDS-5444


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@zamoore zamoore requested a review from a team as a code owner August 27, 2025 21:17
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Aug 27, 2025 9:18pm
hds-website Ready Ready Preview Aug 27, 2025 9:18pm

@zamoore zamoore changed the title Zamoore/code editor/csp nonce fix Add cspNonce argument to Hds::CodeEditor component Aug 27, 2025
Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are you planning to make a separate PR to update the docs site?

@dchyun
Copy link
Contributor

dchyun commented Aug 28, 2025

Looks good! Are you planning to make a separate PR to update the docs site?

Looks like cspNonce is already listed as an argument in the component api docs. I guess it was incorrectly added there previously.

@zamoore
Copy link
Contributor Author

zamoore commented Aug 28, 2025

Looks good! Are you planning to make a separate PR to update the docs site?

Looks like cspNonce is already listed as an argument in the component api docs. I guess it was incorrectly added there previously.

Yep, that was indeed the case. Thanks for the reviews!

@zamoore zamoore merged commit 2eaf2db into main Aug 28, 2025
18 checks passed
@zamoore zamoore deleted the zamoore/CodeEditor/csp-nonce-fix branch August 28, 2025 17:56
@hashibot-hds hashibot-hds mentioned this pull request Aug 28, 2025
@alex-ju alex-ju added this to the [email protected] milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants