Skip to content

Add cspNonce argument to Hds::CodeEditor component #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
+24 −0
Merged

Add cspNonce argument to Hds::CodeEditor component #3132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
208651e
code editor component accepts a cspNonce value and passes it to the m…
zamoore Aug 27, 2025
e0841aa
added changeset
zamoore Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/brown-ways-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@hashicorp/design-system-components": minor
---

<!-- START components/code-editor -->

`CodeEditor` - Added a `cspNonce` argument which passes a value of the same name to the `hds-code-editor` modifier. `cspNonce` is used to add a nonce value to the style tag

<!-- END -->
1 change: 1 addition & 0 deletions packages/components/src/components/hds/code-editor/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
ariaDescribedBy=this.ariaDescribedBy
ariaLabel=@ariaLabel
ariaLabelledBy=this.ariaLabelledBy
cspNonce=@cspNonce
extraKeys=@extraKeys
hasLineWrapping=@hasLineWrapping
isLintingEnabled=@isLintingEnabled
Expand Down
14 changes: 14 additions & 0 deletions showcase/tests/integration/components/hds/code-editor/index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ module('Integration | Component | hds/code-editor/index', function (hooks) {
assert.dom('#test-code-editor').hasClass('hds-code-editor');
});

// cspNonce
test('it should render the injected style tag with the provided `@cspNonce` value', async function (assert) {
const cspNonce = 'csp-nonce-123';

this.set('cspNonce', cspNonce);

await setupCodeEditor(
hbs`<Hds::CodeEditor @cspNonce={{this.cspNonce}} as |CE|><CE.Title>Test Title</CE.Title></Hds::CodeEditor>`,
);

// can't use assert.dom to access elements in head
assert.ok(document.querySelector(`style[nonce="${cspNonce}"]`));
});

// title
test('it should render the component with a title using the default tag', async function (assert) {
await setupCodeEditor(
Expand Down