Resolve ntlm nil pointer bug by bumping go-ntlmssp dependency #8369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwampDragons
force-pushed
the
eof_dieeee
branch
from
d9e4081 to
452ca60
Compare
SwampDragons
changed the title
|
Confirmed that I can't seem to be able to reproduce #5864 with this branch; I think we're good to go. Merging. |
|
Super nice fix :D |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump go-ntlmssp dependency, resolving bug where Negotiator would return nil, nil instead of either a response or an err.
Closes #7685
Closes #8353
Closes #8229
Closes #7350
Closes #7994
Closes #5865
We may also be able to revert hack in #5864 as a result of this change.
The relevant PR in the upstream library is Azure/go-ntlmssp#24