Skip to content

a NonVoter node should never try to bootstrap #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rboyer merged 2 commits into from
Mar 1, 2022
Merged

a NonVoter node should never try to bootstrap #492

rboyer merged 2 commits into from
Mar 1, 2022

Conversation

@rboyer
Copy link
Member

@rboyer rboyer commented Mar 1, 2022 •
edited
Loading

This is a follow-up to #483

TODO:

  • add a test (likely inspired by consul's TestServer_Expect_NonVoters in some way since that's how i noticed the bug)

@rboyer rboyer requested review from banks, dhiaayachi and mkeeler March 1, 2022 17:21
@rboyer rboyer self-assigned this Mar 1, 2022
mkeeler
mkeeler approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rboyer rboyer merged commit 1979b11 into main Mar 1, 2022
@rboyer rboyer deleted the nonvoter-bootstrap branch March 1, 2022 17:59
@rboyer rboyer mentioned this pull request Mar 2, 2022
Merged
@shoenig shoenig mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkeeler mkeeler mkeeler approved these changes

@banks banks Awaiting requested review from banks

@dhiaayachi dhiaayachi Awaiting requested review from dhiaayachi

Assignees

@rboyer rboyer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rboyer @mkeeler