azurerm_container_app – support for termination_grace_period_seconds

[CheeseMite]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add support for termination_grace_period_seconds property of the azurerm_container_app resource

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Change Log

• azurerm_container_app - support for the termination_grace_period_seconds property

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

Hi @CheeseMite thanks for submitting this. This is looking good but it looks like there is a linting error - could you run make terrafmt on the test file which should hopefully fix this? Thanks!

[catriona-m]

Thanks for fixing the linting @CheeseMite - I just left one small query but will take another look soon. Thanks!

[catriona-m]

Thanks @CheeseMite - I just noticed this needs a different docs file, but otherwise this is looking good, thanks!

[catriona-m]

this docs file is for the the datasource, could we move this change to website/docs/r/container_app.html.markdown?

[CheeseMite]

added to the resource doc. No need to remove from the data source docs as both use the same schema

[catriona-m]

Thanks for updating the resource doc @CheeseMite - LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.