New resources: `azurerm_mssql_job` and `azurerm_mssql_job_schedule` by sreallymatt · Pull Request #28456 · hashicorp/terraform-provider-azurerm

sreallymatt · 2025-01-09T00:39:17Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added new resources azurerm_mssql_job and azurerm_mssql_job_schedule

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_mssql_job [New resources: azurerm_mssql_job and azurerm_mssql_job_schedule #28456]
New Resource: azurerm_mssql_job_schedule [New resources: azurerm_mssql_job and azurerm_mssql_job_schedule #28456]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

sreallymatt · 2025-01-09T02:11:34Z

stephybun

Thanks @sreallymatt! This is off to a good start, would you mind taking a look through the comments I left in-line? Once those are resolved this should be good to go!

Co-authored-by: stephybun <steph@hashicorp.com>

stephybun

Thanks @sreallymatt! Provided tests are still passing after latest changes LGTM 💯

* update for #27680 * Update CHANGELOG.md for #28465 * Update CHANGELOG.md #27932 * Update CHANGELOG.md for #28505 * Update CHANGELOG.md for #28474 * Update CHANGELOG.md #28516 * Update CHANGELOG for #28456 * Update CHANGELOG.md for #28472 * Update CHANGELOG.md #28307 * Update CHANGELOG.md for #27859 * Update for #28519 * Update for #27791 #27528 * Update CHANGELOG.md for #28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>

…ashicorp#28456) * New resources: azurerm_mssql_job and azurerm_mssql_job_schedule * Update timeouts * Fix lint * Update struct name to follow convention * Apply suggestions from code review Co-authored-by: stephybun <steph@hashicorp.com> * Update internal/services/mssql/mssql_job_schedule_resource.go Co-authored-by: stephybun <steph@hashicorp.com> * Update based on comments --------- Co-authored-by: stephybun <steph@hashicorp.com>

* update for hashicorp#27680 * Update CHANGELOG.md for hashicorp#28465 * Update CHANGELOG.md hashicorp#27932 * Update CHANGELOG.md for hashicorp#28505 * Update CHANGELOG.md for hashicorp#28474 * Update CHANGELOG.md hashicorp#28516 * Update CHANGELOG for hashicorp#28456 * Update CHANGELOG.md for hashicorp#28472 * Update CHANGELOG.md hashicorp#28307 * Update CHANGELOG.md for hashicorp#27859 * Update for hashicorp#28519 * Update for hashicorp#27791 hashicorp#27528 * Update CHANGELOG.md for hashicorp#28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: jackofallops <ste@hashicorp.com>

github-actions · 2025-02-15T02:13:20Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New resources: azurerm_mssql_job and azurerm_mssql_job_schedule

d293f47

sreallymatt requested a review from a team as a code owner January 9, 2025 00:39

github-actions bot added documentation dependencies service/mssql Microsoft SQL Server size/XL waiting-response labels Jan 9, 2025

Update timeouts

0f4a400

github-actions bot added waiting-response and removed waiting-response labels Jan 9, 2025

Fix lint

e10132e

github-actions bot removed the waiting-response label Jan 9, 2025

Update struct name to follow convention

fffa4e9

stephybun suggested changes Jan 14, 2025

View reviewed changes

github-actions bot assigned stephybun Jan 14, 2025

github-actions bot added the waiting-response label Jan 14, 2025

Apply suggestions from code review

ff5dbcc

Co-authored-by: stephybun <steph@hashicorp.com>

github-actions bot removed the waiting-response label Jan 14, 2025

sreallymatt and others added 2 commits January 14, 2025 07:54

Update internal/services/mssql/mssql_job_schedule_resource.go

a5fdc59

Co-authored-by: stephybun <steph@hashicorp.com>

Update based on comments

7485914

sreallymatt mentioned this pull request Jan 14, 2025

Contributor Docs: Fix minor errors and add additional information #28510

Merged

9 tasks

stephybun approved these changes Jan 15, 2025

View reviewed changes

sreallymatt merged commit 0fa6a35 into main Jan 15, 2025

sreallymatt deleted the mp/mssql-jobs branch January 15, 2025 14:41

github-actions bot added this to the v4.16.0 milestone Jan 15, 2025

rcskosir added the new-resource label Jan 15, 2025

sreallymatt added a commit that referenced this pull request Jan 15, 2025

Update CHANGELOG for #28456

96013ab

github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resources: `azurerm_mssql_job` and `azurerm_mssql_job_schedule`#28456

New resources: `azurerm_mssql_job` and `azurerm_mssql_job_schedule`#28456
sreallymatt merged 7 commits intomainfrom
mp/mssql-jobs

sreallymatt commented Jan 9, 2025 •

edited

Loading

Uh oh!

sreallymatt commented Jan 9, 2025

Uh oh!

stephybun left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephybun left a comment

Uh oh!

github-actions bot commented Feb 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sreallymatt commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Testing

Change Log

Related Issue(s)

Uh oh!

sreallymatt commented Jan 9, 2025

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sreallymatt commented Jan 9, 2025 •

edited

Loading