Propagate unknown and sensitive metadata to dynamic attributes#33057
Merged
liamcervante merged 2 commits intomainfrom Apr 24, 2023
Merged
Propagate unknown and sensitive metadata to dynamic attributes#33057liamcervante merged 2 commits intomainfrom
liamcervante merged 2 commits intomainfrom
Conversation
dd1f9ea to
c196aa2
Compare
jbardin
approved these changes
Apr 21, 2023
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the jsonformat/jsondiff package to include and process the sensitive and computed metadata about the given change.
The package now handles Change objects directly, something that is only possible with the refactor in #33054. This is a good change because now it is actually processing all the information in the change instead of simple subset as it was previously.
The change also moves the logic for processing unknown and sensitive types into the shared structured package so that the differ and the jsondiff package can share the logic.
Fixes #33056
Target Release
1.4.6
Draft CHANGELOG entry
BUG FIXES