Implement kubernetes auth / Add customizable auth path#218
Merged
Conversation
Contributor
Author
|
@jasonodonnell Any chance for a review on this sometime soon? |
Contributor
|
Hi @FalconerTC, thanks for the contribution! This looks great at a glance, but I need to test this before merging. I'm guessing the idea here is to use a remote runner on K8s? |
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Contributor
Author
|
Yep. I use the following tool (https://github.com/actions-runner-controller/actions-runner-controller) currently for self-hosted runners on K8s. |
Contributor
Author
|
@jasonodonnell Any chance you will be able to look at this again this soon? I've validated it authenticates correctly in a private workflow, including validating with a custom path |
This was referenced Jun 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built from #155. Thanks to jojo19893 for most of the work.
This adds support for Kubernetes based auth (https://www.vaultproject.io/docs/auth/kubernetes). It also adds a parameter to customize the path for any auth method.