implemented kubernetes auth#155
Conversation
|
|
|
I think you might need to run a build? https://github.com/hashicorp/vault-action/blob/master/dist/index.js#L14085 <--- i believe this is the bit that gets run, but it does not include your changes. |
|
how can I run a build? |
| roleName: | ||
| description: "The role name for the kubernetes authentification" | ||
| required: false | ||
| tokenPath: |
There was a problem hiding this comment.
This should probably have a default /var/run/secrets/kubernetes.io/serviceaccount/token, which for 99% of the use cases the JWT will be found.
There was a problem hiding this comment.
@jojo19893 Are you still planning on making this change? I can, to get this moving again
|
I'd love to see this merged into the official hashicorp action. I'm presently using curl to perform a vault login and would feel better if I were able to do this via the officially supported vault-action. |
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
|
+1. Would love to see this merged! |
|
#218 implemented this and other features. Now that its merged closing this one. |
6 participants
I felt it was useful to have kubernetes auth for the github action.
This is especially handy if you use self hosted runners that have kubernetes auth with vault.
I also added some basic unit tests for the auth.js